search

aaronger / utility-eval-papers

Pipelines and drafts related to arXiv:2312.16201
0 stars 0 forks source link

change hard-coded dates to argument references #56

Closed nickreich closed 9 months ago

nickreich commented 9 months ago

I think that even if we changed the arguments here to be a different date, these hard-coded dates might override the changes: https://github.com/aaronger/utility-eval-papers/blob/248586a2618a40cff1f9a342031d12b47fb8e283/R/plot_functions.R#L68

aaronger commented 9 months ago

Will change to 

  target_dates <- data.frame(
    Date = as.Date(c(f_date, te_date))) %>% 
    dplyr::mutate(Date_name = paste0(c("Forecast Date, ", "Target Date, "), Date))