aarron-lee / SimpleDeckyTDP

Decky TDP plugin for alternative PC handhelds
Other
51 stars 8 forks source link

Overriding legion space tdp #33

Open greyhawk1123 opened 6 months ago

greyhawk1123 commented 6 months ago

Sdtdp is overriding windows tdp and legion space custom tdp will only follow the set tdp under sdtdp unless legion space tdp set to lowest value.

Happening even while bazzite was uninstalled and removed from SSD

aarron-lee commented 6 months ago

Sdtdp is overriding windows tdp and legion space custom tdp will only follow the set tdp under sdtdp unless legion space tdp set to lowest value.

SDTDP is not intentionally overriding the Windows TDP, it's just using the exact same bios functions that LegionSpace itself uses for to set TDP.

The functions were reverse engineered from LegionSpace itself, so SDTDP is effectively just doing exactly what LegionSpace should be doing to set TDP.

To me this sounds like a LegionSpace bug, where LegionSpace is not properly setting the TDP values via the bios functions.

edit: for anybody curious about technical details, see https://github.com/aarron-lee/SimpleDeckyTDP/issues/25