Code Signing for resources turned off

abbeycode / UnrarKit

Easily read RAR archives on Mac and iOS

BSD 2-Clause "Simplified" License

313 stars 93 forks source link

Code Signing for resources turned off #105

Closed gpotari closed 2 years ago

gpotari commented 2 years ago

Fixes Code Signing issue for Resources as per our discussion

Summary:

When using UnrarKit in any iOS or Mac project, it always require to set a valid team and provisioning profile. It is not necessary to check Automatically manage sining , so I turned it off.

abbeycode commented 2 years ago

Thanks, this looks great. I looked at the blame for the line and it seems like that was just the default setting for the new target. It mainly affects authors, not consumers, since if you're using CocoaPods it shouldn't matter. Carthage might, but I imagine it won't cause problems.

Let's resolve #103 and then I'll merge this in after (after we handle any merge conflicts).

gpotari commented 2 years ago

Thank you , can we merge back this pr please ?

abbeycode commented 2 years ago

Done. Thanks again for the suggestion and implementation!