Support Windows - Githubissues

abentley / oaf

A Git client that brings a more user-friendly CLI to Git.

Apache License 2.0

9 stars 1 forks source link

Support Windows #60

Open ghost opened 1 year ago

ghost commented 1 year ago

error[E0433]: failed to resolve: could not find `unix` in `os`
  --> src\commands.rs:25:14
   |
25 | use std::os::unix::process::CommandExt;
   |              ^^^^ could not find `unix` in `os`

abentley commented 1 year ago

Hi Steven, thanks for trying out oaf! I'm sorry it didn't compile for you. I do all my dev work on Linux, (or WSL), so Windows and Mac have been a blind spot.

The two reasons for *nixisms are

supporting exec. This could be worked around by simply using run() on platforms where exec isn't supported.
supporting converting the output of commands to OsString without enforcing a particular encoding. It's a bit unclear to me how this would work on Windows. There seems to be a mismatch between u8 and u16 characters in the low-level apis.

ghost commented 1 year ago

supporting exec

this is concerning. why is this needed in the first place? are you trying to call git.exe or something? I am searching for a Git client/implementation that doesn't rely on any external commands. The official C implementation on Windows has some issues, so I have been trying to find a replacement, but I dont want something that is simply relying on the existing C Git implementation.

ghost commented 1 year ago

oh dear:

https://github.com/abentley/oaf/blob/b693fb5ad96704c060c633a86713e6975be6458e/src/git.rs#L35-L39

you should probably make it clear in the Readme that Oaf is essentially a wrapper for an existing Git installation. I do see this now:

Git must be installed for Oaf to function. Oaf is typically tested with Git 2.25.x

but I feel that info could be moved higher up or be made more prominent.

abentley commented 1 year ago

I will make it clearer that Oaf mainly wraps existing commands. Sorry it's not what you're looking for.