Open README from project root, and properly close file

abhinavsp0730 / blip

Python package to intercept an mock all external api calls during django test.

MIT License

2 stars 4 forks source link

Open README from project root, and properly close file #6

Closed Mango0x45 closed 1 year ago

Mango0x45 commented 1 year ago

open("README").read() fails to actually close the file after reading. Additionally we can use file to always grab the README from the project root regardless of where the setup file is called from.

abhinavsp0730 commented 1 year ago

Hey, thanks for the contribution. I have to close your PR because someone else opened the PR before you for the same issue. And he's beginner. Hope you don't mind :(. Apologies and thanks again.

Mango0x45 commented 1 year ago

No worries!

Mango0x45 commented 1 year ago

@abhinavsp0730 can you at least leave the hacktoberfest-accepted label here so it counts?

abhinavsp0730 commented 1 year ago

Hey @Mango0x45 added. Thanks :).