abishekvashok / cmatrix

Terminal based "The Matrix" like implementation
GNU General Public License v3.0
4.05k stars 423 forks source link

Disabling Background Color #146

Closed h3x4g0ns closed 1 year ago

h3x4g0ns commented 2 years ago

Is it possible to disable to background color when cmatrix runs? I have a color theme applied in the terminal so when cmatrix runs, there's a gray background underneath.

Screenshot_2022-04-21-05-59-22_3440x1440

abishekvashok commented 2 years ago

Can you try building with make and using code from the development branch please?

nikoof commented 2 years ago

It seems the background color depends on whether use_default_colors is used. And that depends on whether HAVE_USE_DEFAULT_COLORS is defined, which the autoconf script does, but not the CMakeLists.txt file, so I figure that the package you're using was configured with cmake and that's why it's missing this feature.

Checking for the function and defining that macro in the cmake script should solve it.

lilly-lizard commented 1 year ago

just tried building this with default autoconf config and there's no background which is great! just a fyi in case this could be closed.

abishekvashok commented 1 year ago

Yes, I think it works via autotools and doesn't work with cmake. I think we could use the commit authored by @Nikoof on his fork. @Nikoof would you like to make a pr from your fork?

nikoof commented 1 year ago

Will do!

abishekvashok commented 1 year ago

Seems like #168 closes this, let me know if it doesn't :)