search

abishekvashok / cmatrix

Terminal based "The Matrix" like implementation
GNU General Public License v3.0
4.02k stars 417 forks source link

Support for larger terminal size than 132x300 #18

Closed nlutsenko closed 6 years ago

nlutsenko commented 7 years ago

As README points out cmatrix by default supports resolutions up to 132x300. I tried to put it running a terminal window under 204x87 (basically half of vertical display), and yes, 204 columns is an overkill, but hey, let's try to have nice things.

The current issue is that after about 1/3 of the window fils up with characters - it starts to lag immediately and gives me a feeling that The Matrix has a hard time processing some data or keeps changing so many things at once.

Would be great to support higher resolutions without the lag!

P.S. Could help figure out and contribute to this, but would need some pointers to where to get started and where the bottleneck could be.

abishekvashok commented 7 years ago

@nlutsenko hi sorry for a late response. cmatrix can support resolutions larger than 132x300.

The current issue is that after about 1/3 of the window fils up with characters - it starts to lag immediately and gives me a feeling that The Matrix has a hard time processing some data or keeps changing so many things at once.

We are having to generate characters at an overwhelming rate in such situations. But yes, we will have a look into this. Let's see if we could improve the logic of the program.

livibetter commented 6 years ago

@nlutsenko I think you are confused by the CMatrix's special effects that's turned on by default for big terminal sizes. The slowness you observe, it's, in fact, slow-mo bullet time in effect, and for even bigger terminal size, which varies with computer's processing power, you would see more outstanding effect, which literally standing still, like the face punch scene. CMatrix stays true to the Matrix, and these two features can not be switched off. /jk

Joking aside, the issue title should be changed to like "Improve the performance" or something like that as CMatrix supports 132x300 or any sizes, there is no hard-coded limit in the code, as long as the terminal emulator and ncurses can do it, and you computer can handle it.

abishekvashok commented 6 years ago

We will open another issue for that. Closing due to inactivity of the issue author.