search

ably / ably-asset-tracking-swift

iOS client SDKs for the Ably Asset Tracking service.
Apache License 2.0
9 stars 6 forks source link

Fix capitalisation of `VehicleProfile` case names #416

Closed lawrence-forooghian closed 1 year ago

lawrence-forooghian commented 1 year ago

CI broken; awaiting https://github.com/ably/ably-asset-tracking-swift/pull/417 to be merged.

JakubJankowski commented 1 year ago

Could we also assign a String type to this enum, and make it conform to Codable, like I did in pr 418?

It would make life easier when it comes to encoding/decoding, for example where I'm fetching/saving it in UserDefaults here

In our current codebase I see that we already have a couple of enums declared similarly to this, so I don't think it would be breaking any conventions.

lawrence-forooghian commented 1 year ago

Could we also assign a String type to this enum

What would be the reason for this? It seems like an unnecessary restriction to me.

and make it conform to Codable, like I did in pr 418?

It would make life easier when it comes to encoding/decoding, for example where I'm fetching/saving it in UserDefaults here

I think it makes sense for you to continue adding the Codable conformance at the point where we actually need it, i.e. in your PR.