Choose vehicle profile in the settings screen

ably / ably-asset-tracking-swift

iOS client SDKs for the Ably Asset Tracking service.

Apache License 2.0

9 stars 6 forks source link

Choose vehicle profile in the settings screen #418

Closed JakubJankowski closed 1 year ago

JakubJankowski commented 1 year ago

Resolves 408

I made some minor breaking changes to the VehicleProfile enum, since (at least in this project) the convention is to use lowercase when naminng enum cases. I also made it a String type, and made it conform to Codable. Please let me know if you think changes like this are ok.

lawrence-forooghian commented 1 year ago

I'd like to take a look at this one (specifically the API changes) but I won't have a chance until Monday. Please could you hold off on merging until I've taken a look? Thanks!

lawrence-forooghian commented 1 year ago

@JakubJankowski the enum capitalisation changes are already in https://github.com/ably/ably-asset-tracking-swift/pull/416; please could you take a look at that one?