search

ably / ably-asset-tracking-swift

iOS client SDKs for the Ably Asset Tracking service.
Apache License 2.0
9 stars 6 forks source link

Location Source: S3 file #435

Closed arturjaworski closed 1 year ago

arturjaworski commented 1 year ago

Closes #410, closes #290, closes #411, closes #436

Created #437 for documentation (@lawrence-forooghian will address)

JakubJankowski commented 1 year ago

One thing that's missing is some info in the Readme.md ## Example Apps section on how to use this feature. What's the amplifyconfiguration file? Where can users get it from? etc.

It doesn't have to be a part of this PR, but in that case I'd create a separate issue for this and handle it rather soon-ish.

arturjaworski commented 1 year ago

One thing that's missing is some info in the Readme.md ## Example Apps section on how to use this feature. What's the amplifyconfiguration file? Where can users get it from? etc.

It doesn't have to be a part of this PR, but in that case I'd create a separate issue for this and handle it rather soon-ish.

Its already created #437

arturjaworski commented 1 year ago

One CI action is failing, but it's looks like Xcode bug. New Xcode should be released soon with iOS 16.1, so I'm not sure does it make sense to fix it.

lawrence-forooghian commented 1 year ago

I'll take a look at this today, thanks!

lawrence-forooghian commented 1 year ago

I'll review this PR and take responsibility for any changes needed, now that @arturjaworski is no longer on the project.

I'm assuming the issue mentioned in the PR description is meant to be #290, not 230 (which is very unrelated). Have updated PR description.

lawrence-forooghian commented 1 year ago

There's nothing in the commits or PR description to explain why we've changed Xcode version / simulator. I'll switch that back to see what I can find out.

lawrence-forooghian commented 1 year ago

OK, I'm assuming that the update was due to this error:

xcodebuild: error: Could not resolve package dependencies:
[6931](https://github.com/ably/ably-asset-tracking-swift/actions/runs/3320947815/jobs/5487945236#step:6:6932)
  Dependencies could not be resolved because 'amplify-swift' >= 2.0.0 contains incompatible tools version (5.6.0) and root depends on 'amplify-swift' 2.0.0..<3.0.0.