search

ably / ably-asset-tracking-swift

iOS client SDKs for the Ably Asset Tracking service.
Apache License 2.0
9 stars 6 forks source link

Add file name and line number info to log messages #509

Closed lawrence-forooghian closed 1 year ago

lawrence-forooghian commented 1 year ago

This adds a tag like @(MyFile.swift:130) to each log message, identifying the source code file and line number from which the log message was emitted.

Please review commit-by-commit (it has a couple of refactors that might be difficult to review otherwise) and see commit messages for more details.

Closes #494.

lawrence-forooghian commented 1 year ago
  • Would it be worthwhile adding some guidance to the contributing guide relating to adding log output to this SDK?

Good point. It's probably not directly relevant to this PR; I should have done it in #508. But I've added 848d1dfb7d0277720acb3828df2e99a64319ac4b to address it here.

  • Does this change need to include modification to the Generating mocks section of the aforementioned contributing guide?

It does, thanks! Added 539d5e030c9ae4da7b2cda5fa166dd8c630b2841.