ably / ably-asset-tracking-swift

iOS client SDKs for the Ably Asset Tracking service.
Apache License 2.0
9 stars 6 forks source link

Failing tests are sometimes missing from JUnit report uploaded to test observability server #513

Closed lawrence-forooghian closed 1 year ago

lawrence-forooghian commented 1 year ago

For example, see https://github.com/ably/ably-asset-tracking-swift/actions/runs/3679080639/jobs/6235577712; the following tests are failing (and many others):

But none of those appear in the JUnit report uploaded to the test observability server.

Also, the number of tests per upload seems to be varying wildly (see the "Total number of tests" column here).

sync-by-unito[bot] commented 1 year ago

➤ Automation for Jira commented:

The link to the corresponding Jira issue is https://ably.atlassian.net/browse/SDK-3180

lawrence-forooghian commented 1 year ago

I've pushed the code with the failures to https://github.com/ably/ably-asset-tracking-swift/tree/513-example-of-missing-tests-in-junit-report so we can reproduce this later. It's happening because the tests are causing a nil implicitly unwrapped optional to be unwrapped, and the test process is crashing. This seems to be an issue in how xcpretty is converting the xcodebuild output that's piped in to it. I'll upload an example of this xcodebuild output later.

lawrence-forooghian commented 1 year ago

OK, here's an example of an xcodebuild log, and the corresponding .xcresult bundle. Both from my machine.