search

ably / ably-asset-tracking-swift

iOS client SDKs for the Ably Asset Tracking service.
Apache License 2.0
9 stars 6 forks source link

Rework the sdk to use workers and worker queue to handle events #523

Closed JakubJankowski closed 1 year ago

JakubJankowski commented 1 year ago

The approach should be aligned to the way it's handled on the Android sdk.

More details will be added later.

sync-by-unito[bot] commented 1 year ago

➤ Automation for Jira commented:

The link to the corresponding Jira issue is https://ably.atlassian.net/browse/SDK-3263

lawrence-forooghian commented 1 year ago

What's the scope of this issue, @JakubJankowski? Are you reproducing the worker mechanism and all the workers exactly as they exist in Android? (If so, that sounds like a lot of work for one issue, and also quite difficult since the Android workers are changing a lot at the moment.) Or is it just to introduce the mechanism and then slowly bring the individual workers in line with Android?

lawrence-forooghian commented 1 year ago

It would be good, as a first piece of work, to maybe do a PR that just introduces the worker queue and related protocols and tests?

JakubJankowski commented 1 year ago

Hey @lawrence-forooghian - my plan is to introduce the WorkerQueue and rework the current implementation of the subscriber sdk. The scope is indeed quite large.

I think it's indeed a good idea to set up the WorkerQueue and related interfaces as a separate PR first, to make sure we're all on the same page on how it should be implemented on iOS, so I'll extract this part from my current work, finish it up and I'll submit a PR for it.

lawrence-forooghian commented 1 year ago

I think it's indeed a good idea to set up the WorkerQueue and related interfaces as a separate PR first, to make sure we're all on the same page on how it should be implemented on iOS, so I'll extract this part from my current work, finish it up and I'll submit a PR for it.

Sounds good, thanks!