search

ably / ably-asset-tracking-swift

iOS client SDKs for the Ably Asset Tracking service.
Apache License 2.0
9 stars 6 forks source link

Worker Queue: Legacy #569

Closed AndyTWF closed 1 year ago

AndyTWF commented 1 year ago

As part of the worker queue migration, we could adapt the current publishers do async work method to push that work onto the worker queue (a generic worker - takes a simple callback and runs it). That way we can confine all the async work to the queue, as we refactor out the workers.

Depends on the following work:

sync-by-unito[bot] commented 1 year ago

➤ Automation for Jira commented:

The link to the corresponding Jira issue is https://ably.atlassian.net/browse/SDK-3382

lawrence-forooghian commented 1 year ago

@AndyTWF To check I’ve understood – the idea here is to instantiate a worker queue inside DefaultPublisher and DefaultSubscriber, and to replace their performOnWorking{Thread, Queue} methods with a method that enqueues this generic function-calling worker, right?

lawrence-forooghian commented 1 year ago

Also, it says that it depends on #590, but that seems to be publisher specific whereas I assumed this one was about publisher and subscriber. I also don't think that we need the full properties types (i.e. #570) to be implemented in order to do this one – we just need empty placeholder properties types for publisher and subscriber, right?