Feature/593 subscriber properties

ably / ably-asset-tracking-swift

iOS client SDKs for the Ably Asset Tracking service.

Apache License 2.0

9 stars 6 forks source link

Feature/593 subscriber properties #617

Closed JakubJankowski closed 1 year ago

JakubJankowski commented 1 year ago

This PR introduces the implementation of SubscriberProperties, to be used by WorkerQueue on the Subscriber side of the sdk. I tried to keep the implementation as close to Android's approach as possible. However we've decided to, at least for now, stick to the Delegation pattern to notify the API consumers about state changes, instead of switching to the Kotlin's streams (SharedFlow) approach.

Resolves #593

lawrence-forooghian commented 1 year ago

@JakubJankowski did you see the CI failure here? I’ll put it back in to draft for now.

JakubJankowski commented 1 year ago

As mentioned in one of our calls - any suggestions on how to handle the naming of LocationsPublishingState, TrackableState and ConnectionState are welcome. I've decided for now to preserve the ConnectionState name, so that the API wouldn't change too much, but the TrackableState would fit better and would align with the naming in Kotlin.