search

accre / lstore

LStore - A fault-tolerant, performant distributed data storage framework.
http://www.lstore.org
Apache License 2.0
4 stars 5 forks source link

Hopefully the final merge ofthe pre-factored code! #119

Closed tacketar closed 8 years ago

PerilousApricot commented 8 years ago

@tacketar In the future, please push your branches to your own fork then issue the PR from your fork to the main one. It's not a huge deal, but it kinda busts things up with Jenkins a bit to have the origin branch be from the same remote. The change in procedure is effectively push origin feature/partyhouse with push me feature/partyhouse.

I can tidy it up manually, but it's much preferred in the future.

tacketar commented 8 years ago

Will do. Sorry about that.

PerilousApricot commented 8 years ago

No biggie. You're just now seeing all the bits that I've been slamming on for a few months. Notice the nice "pending check"? :)

PerilousApricot commented 8 years ago

s/merge ofthe pre-factored/merge of the pre-factored/

PerilousApricot commented 8 years ago

This build fails because it requires LevelDB, but LevelDB isn't shipped along with the docker builder images:

-- The following REQUIRED packages have not been found:

 * LevelDB

CMake Error: The following variables are used in this project, but they are set to NOTFOUND.
Please set them or make sure they are set and tested correctly in the CMake files:
/tmp/lstore-package/src/lio/LEVELDB_INCLUDE_DIR

You'll need to add the appropriate statements to https://github.com/accre/lstore/blob/master/scripts/generate-docker-base.sh#L78, https://github.com/accre/lstore/blob/master/scripts/generate-docker-base.sh#L99 to instruct the build system about the new dependencies. Additionally, please update the documentation at https://github.com/accre/lstore/blob/master/README.md to tell humans of the new dep.

tacketar commented 8 years ago

Good catch. I completely forgot about the docker builder.

tacketar commented 8 years ago

Superseeded by #129