search

accre / lstore

LStore - A fault-tolerant, performant distributed data storage framework.
http://www.lstore.org
Apache License 2.0
4 stars 5 forks source link

Bugfix/dns size #161

Closed tacketar closed 7 years ago

PerilousApricot commented 7 years ago

I'm not sure I get the fix -- are you moving from allocating 16 bytes for the result of DNS lookup to the 4 bytes? Is that the opposite direction we want to go? (i.e. ipv4 vs ipv6)

tacketar commented 7 years ago

Yes and Yes. The current approach has just a few placeholders to support v4 and v6 but it's nowhere near fleshed out. I had a choice to either hard code the memcpy to 4 bytes or change the global size constant from 16->4 to accomplish the same thing. I opted for the constant to make it perfectly clear that the library only supports IPv4 in it's current state. Once we get our IPv6 addresses it should be straightforward to add proper dual support at that time.