accre / lstore

LStore - A fault-tolerant, performant distributed data storage framework.
http://www.lstore.org
Apache License 2.0
4 stars 5 forks source link

pull ZMQ #include out of public headers #184

Open PerilousApricot opened 5 years ago

PerilousApricot commented 5 years ago

Are we exporting ZMQ types?

[meloam@xrootd1 xrootd-hdfs]$ make
[ 25%] Building CXX object CMakeFiles/XrdLstore.dir/src/XrdLstoreInit.cc.o
[ 50%] Building C object CMakeFiles/XrdLstore.dir/src/XrdLstoreStub.c.o
In file included from /usr/include/lio/lio.h:24:0,
                 from /home/meloam/xrootd-hdfs/src/XrdLstoreStub.c:10:
/usr/include/gop/mq.h:26:17: fatal error: zmq.h: No such file or directory
 #include <zmq.h>
                 ^
compilation terminated.
tacketar commented 5 years ago

Looks like the entire dependency is on: typedef zmq_pollitem_t gop_mq_pollitem_t;

define gop_mq_poll(items, n, wait_ms) zmq_poll(items, n, wait_ms)

We do require ZMQ be installed for building from scratch so I've never tried to build a clean standalone app. Feel free to try and re-work this if you want. Otherwise just put it as a todo for me.

In the interim you could just install the headers:(

PerilousApricot commented 5 years ago

Right, this is me installing lstore, lstore-devel and trying to build against that. I'll look once I get this xrootd stuff wrapped