Drop our apr* forks - Githubissues

accre / lstore

LStore - A fault-tolerant, performant distributed data storage framework.

http://www.lstore.org

Apache License 2.0

4 stars 5 forks source link

Drop our apr* forks #90

Open PerilousApricot opened 8 years ago

PerilousApricot commented 8 years ago

Running build tests and such is dominated by the time it takes to build APR. What are the patches we're carrying? Can we upstream them?

tacketar commented 8 years ago

We have 2 patches:

1) Making the threadpool threadsafe. This could most likely be upstreamed. 2) Make APR network Read/Write routines thread safe. This most likely will not get accepted because someone went to a fair amount of effort to do some internal optimizations (that we'd never care about and about provide a dubious performance boost in any case).

PerilousApricot commented 8 years ago

The threadpool stuff is like a page of code that we don't like that much anyway, why don't we just pull that one file out and put it into the tbx library
Network read/write isn't rocket science, even doing it cross-platform, that can be pulled out too.

If those are the only holdups, let's not worry about upstreaming it, just strip out/reimplement what we need.

PerilousApricot commented 8 years ago

In the interim. I added an option "ENABLE_UPSTREAM_APR" to CMake to have find_library(APR) get the non "-ACCRE" suffixed library, It obviously has the broken thread safety still, but it's useful to build things more quickly.