Open junderwood opened 11 years ago
vlaskine
commented
11 years ago thumb is a helper, not full-fledged view: either fixed post-stamp size or resized to given width; it is quite hard to add sensible semantics to it for some reasons; i may add more variants in future
cv-cat --help --verbose documents all the filters and their usage; please let me know if anything is missing
junderwood
commented
11 years ago Sure. It’s already useful as is, so no rush.
I think the semantics should be identical to resize, and that the implementation details would allow significant code reuse to that effect.
From: vlaskine [mailto:notifications@github.com] Sent: Friday, 23 August 2013 12:14 PM To: acfr/snark Cc: junderwood Subject: Re: [snark] cv-cat: thumb=0.2 (#53)
thumb is a helper, not full-fledged view: either fixed post-stamp size or resized to given width; it is quite hard to add sensible semantics to it for some reasons; i may add more variants in future
cv-cat --help --verbose documents all the filters and their usage; please let me know if anything is missing
— Reply to this email directly or view it on GitHub https://github.com/acfr/snark/issues/53#issuecomment-23139462 .Image removed by sender.
vlaskine
commented
11 years ago "I think the semantics should be identical to resize, and that the implementation details would allow significant code reuse to that effect."
the problem is that "thumb" shares semantics of both "resize" and "view"
that's the reason why it is hard to get it right without introducing name-value parameters for filters, which may be a useful thing, but i would like to have the second use case
specifying thumb size seems to only work if you say thumb=width,height in pixels. I thought it would have the same syntax as resize, including rations resize=0.25 and resize=0.25,0.3 - which has proved very useful. At a minimum, it'd be good if the --help / --long-helpcould still list all the available filters and their usage.