Foreign Key Lookup Transform doesn't set the field to nil if resolver fails

activewarehouse / activewarehouse-etl

Extract-Transform-Load library from ActiveWarehouse

MIT License

240 stars 102 forks source link

Foreign Key Lookup Transform doesn't set the field to nil if resolver fails #133

Open colinux opened 11 years ago

colinux commented 11 years ago

Hello,

If a resolver fails, a ResolverError is raised (in foreign_key_lookup_transform.rb#L47). This exception is catched in engine.rb#L385, but nil has not been set to the field (row[name] has not been updated line 382 because of the exception).

Is this the excepted behavior and the doc is wrong or is it a bug? (and I probably could propose a PR)

Thanks!

thbar commented 11 years ago

Hi!

I need to verify what's the historically expected behaviour on existing project - will let you know!

-- Thibaut