search

adafruit / Adafruit_CircuitPython_BME280

CircuitPython driver for the BME280
MIT License
64 stars 42 forks source link

adafruit_bme280.py: Fix the value of dig_H5 #18

Closed robert-hh closed 5 years ago

robert-hh commented 5 years ago

The calculation of dig_H5 from the calibration data did not match the definition of the data sheet and the Bosch sample code. As a result, the compensated relative humidity data could have been calculated wrong.

caternuson commented 5 years ago

@ladyada More info over in the issue thread, #17. I'd say this is good. It has a significant effect on the reading, see below. Anything else before a merge? (@kattni same Q for you)

CURRENT LIBRARY:

Adafruit CircuitPython 3.1.1 on 2018-11-02; Adafruit ItsyBitsy M4 Express with samd51g19
>>> import bme280_simpletest

Temperature: 27.4 C
Humidity: 31.0 %
Pressure: 1010.2 hPa
Altitude = 25.21 meters

Temperature: 27.4 C
Humidity: 31.0 %
Pressure: 1010.2 hPa
Altitude = 25.15 meters

WITH #18 :

Adafruit CircuitPython 3.1.1 on 2018-11-02; Adafruit ItsyBitsy M4 Express with samd51g19
>>> import bme280_simpletest

Temperature: 27.4 C
Humidity: 40.8 %
Pressure: 1010.2 hPa
Altitude = 25.26 meters

Temperature: 27.4 C
Humidity: 40.9 %
Pressure: 1010.2 hPa
Altitude = 25.17 meters
kattni commented 5 years ago

Nothing from me!