Closed yugyesh closed 3 years ago
nice! can you run black
on your example? that will format it nicely
@kattni can help you if you dont know how
@yugyesh Do you need assistance running Black on your code? We can't merge it until CI passes, and there are two issues making it fail - one is that you need to run black to format it properly, and two, you need to add licensing info at the top of the file. Please let me know if this is something you're interested in doing. I can assist you over the next couple of days if needed.
Dear Kattni, I hope this email finds you well in your good health This is my first time contributing to open source. I will be grateful for your assistance in running black on the source code. I am not familiar on with black. In addition, could you please elaborate what licensing I must add in the source code. I will be happy to have your quick response. Thank you
Best regards KC YUGESH Software engineer, Intelligence Design, South korea
On Tue, Mar 16, 2021 at 12:29 AM Kattni @.***> wrote:
@yugyesh https://github.com/yugyesh Do you need assistance running Black on your code? We can't merge it until CI passes, and there are two issues making it fail - one is that you need to run black to format it properly, and two, you need to add licensing info at the top of the file. Please let me know if this is something you're interested in doing. I can assist you over the next couple of days if needed.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/adafruit/Adafruit_CircuitPython_BNO08x/pull/14#issuecomment-799512146, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEJAOQQ5CJD4GBRUKFARFGLTDYRU3ANCNFSM4VUF4ZEQ .
Hello @yugyesh! Thank you for your submission, I really appreciate it. I have reopened this PR, so you edit within this PR and it will update.
I'm realising that you may have submitted this through GitHub. Am I correct in thinking that? Did you use this interface to "Add a file" and then submit the PR that way? Please let me know.
I have a Learn guide that explains how to run Black. Please start by reading this: https://learn.adafruit.com/improve-your-code-with-pylint/black
If you have any questions after reading the guide, please post them here.
For licensing, you need to add the following to the top of the file:
# SPDX-FileCopyrightText: 2021 KC YUGESH
# SPDX-License-Identifier: Unlicense
You can change Unlicense
to a license of your choice, such as MIT
if you wish. Or you can leave it as Unlicense
.
Hello @kattni yes I have used the github interface to in order to initiate the pull request. However the suggested changes has been performed using git bash.
Even after formatting using black the check is getting failed
Using rotation vectors to find the heading value