search

adafruit / Adafruit_CircuitPython_BNO08x

Helper library for the Hillcrest Laboratories BNO080 IMU
MIT License
22 stars 29 forks source link

improving_docs #23

Closed jposada202020 closed 3 years ago

jposada202020 commented 3 years ago

@dhalbert This one is a little different, I would like some feedback on how to deal with the different speed in the buses. I have not change yet the busio reference waiting for your feedback, however all the rest is done. If you could guide me, there is also the BNO08x_RVC that is setup in the same way,

Thanks,

evaherrada commented 3 years ago

Nice job getting the docs to build!

jposada202020 commented 3 years ago

Danh let me know if you have any other comments, gladly to work on that, if None I think that we could make the changes. Thanks

evaherrada commented 3 years ago

@jposada202020 Do you think you could reopen this branch and make another PR? I messed something up with moving to main and this PR wasn't included in the main branch.

jposada202020 commented 3 years ago

@dherrada No problem I could that tonight. Just to clarify, I need to resubmit PR? to main, is that correct? just to be sure and apply the same for all the others :) thanks

evaherrada commented 3 years ago

@jposada202020 Yep. Luckily the mistake that I made seems to not have affected many libraries, but 2 or 3 PRs you made were affected and I've pinged you in all of them. I'm not really sure how late you can reopen a branch or if you have it saved locally, so let me know if you've got questions.

jposada202020 commented 3 years ago

@dherrada Ok, Understood, depends on how often I work in the library, I have or have not the branch. But I will figure it out. And make the changes accordingly.

evaherrada commented 3 years ago

@jposada202020 Sounds good.