search

adafruit / cookiecutter-adafruit-circuitpython

Cookiecutter template for Adafruit's CircuitPython libraries.
MIT License
22 stars 37 forks source link

Pre-Commit requires specific versions be used #102

Closed askpatrickw closed 3 years ago

askpatrickw commented 3 years ago

Fixes #99

Pre-Commit requires specific versions be used. I used the latest for re-use and black as of today.

askpatrickw commented 3 years ago

@kattni I reformatted the text in the original issue, it was wide and hard to see, but there is a pre-commit failure:

Warning:  The 'rev' field of repo 'https://github.com/python/black' appears to be a mutable reference
(moving tag / branch).  
Mutable references are never updated after first install and are not supported. 
See https://pre-commit.com/#using-the-latest-version-for-a-repository for more details.

Warning:  The 'rev' field of repo 'https://github.com/fsfe/reuse-tool' appears to be a mutable reference
(moving tag / branch). 
Mutable references are never updated after first install and are not supported. 
See https://pre-commit.com/#using-the-latest-version-for-a-repository for more details.

Basically as-is your cache will never get updated. Maybe (?) not an issue for a github action, but definitely a problem when run locally.

I wonder if we could control the version with a github secret, at least for Adafruit libraries. I'll look at that when I look at PR #84 as well and let you know.

kattni commented 3 years ago

@askpatrickw Thank you! Let me know what you find out.

kattni commented 3 years ago

For the record:

Since when does the pre-commit require a specific version number?

Since 7 days ago. This PR is necessary.