search

adafruit / cookiecutter-adafruit-circuitpython

Cookiecutter template for Adafruit's CircuitPython libraries.
MIT License
22 stars 37 forks source link

ci(pre-commit): bump pre-commit hooks #182

Closed drts01 closed 2 years ago

askpatrickw commented 2 years ago

@kattni Did you want to bump these versions?

kattni commented 2 years ago

@xsc27 Thanks for the submission! Do you have any idea what changes between the currently pinned version of pre-commit-hooks and the latest version?

Unfortunately, updating Pylint means fixing all of the libraries to work with the latest version of Pylint, which we do not currently have the cycles for. Basically if we update pre-commit pins here, we need to update them across the libraries as well for consistency. Therefore, Pylint should not be updated.

As long as the reuse-tool and pre-commit-hooks updates will not break things in the libraries, I'm happy to update those.

drts01 commented 2 years ago

hmm. pylint will probably need an update to the rcfile to disable any new checks, at a minimum.

The reuse-tool adds support for more files.

pre-commit-hooks adds new hooks (which are not added to the cookie-cutter). Other additions include:

drts01 commented 2 years ago

@kattni new push w/o bumping pylint