search

adafruit / cookiecutter-adafruit-circuitpython

Cookiecutter template for Adafruit's CircuitPython libraries.
MIT License
22 stars 37 forks source link

Always generate PyPI infrastructure #200

Closed tekktrik closed 2 years ago

tekktrik commented 2 years ago

Per @jepler's and @evaherrada's work to ensure all packages are available on PyPI for Mu, this PR updates the cookiecutter so that this infrastructure is always generated and is no longer one of the configurable options.

Resolves #191

tekktrik commented 2 years ago

Community libraries need to set up things in the repository like secrets, but there's no downside for community libraries for providing the infrastructure, even if they don't use it.

askpatrickw commented 2 years ago

Since the GH Action is part of the template, it would be good to document that in the README.rst.

https://github.com/adafruit/cookiecutter-adafruit-circuitpython/blob/main/%7B%7B%20cookiecutter.__dirname%20%7D%7D/.github/workflows/release.yml#L60

- name: Build and publish
      if: contains(steps.need-pypi.outputs.pyproject-toml, 'pyproject.toml')
      env:
        TWINE_USERNAME: {% raw %}${{ secrets.pypi_username }}{% endraw %}
        TWINE_PASSWORD: {% raw %}${{ secrets.pypi_password }}{% endraw %}
tekktrik commented 2 years ago

Added instruction to cookiecutter repo README for adding secrets

tekktrik commented 2 years ago

Rebased this, to get access to the formatting but otherwise the same