search

adafruit / cookiecutter-adafruit-circuitpython

Cookiecutter template for Adafruit's CircuitPython libraries.
MIT License
22 stars 37 forks source link

`set-output` is deprecated in github actions #208

Closed 2bndy5 closed 1 year ago

2bndy5 commented 2 years ago

I'm getting this warning for every build/release workflow run:

The set-output command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Looks like changes will need to be made in the cookiecutter's CI worlflows, specifically about normalizing the repo name for circuitpython-build-tools arguments.

tekktrik commented 2 years ago

Noticed this while working on the new composite actions. As far as resolving the depreciation issue, I can fix it there and I'm hoping to roll out the new CI here and to the libraries shortly,

tekktrik commented 2 years ago

See also https://github.com/adafruit/workflows-circuitpython-libs/issues/3

jepler commented 2 years ago

Yes I was also thinking this would wait until after the transition to the new workflow style

tekktrik commented 2 years ago

Looks like we have until June 2023, so I'll try not to go TOO slow! :snail:

2bndy5 commented 2 years ago

I already solved this in my own workflows.

There's also a warning about csexton/release-asset-action still using node.js v12. I have found a more frequently maintained action that can do the same thing, so I don't get the deprecation warnings anymore.

dhalbert commented 2 years ago

I have found a more frequently maintained action that can do the same thing

What did you find?

2bndy5 commented 2 years ago

https://github.com/shogo82148/actions-upload-release-asset

It requires the upload URL, but that can be fetched via the context of the github event. Multiple files are supported using a glob pattern as well. See my release CI for the nRF24L01 lib. I have tested it with my CircuitPython_Homie lib releases.

tekktrik commented 2 years ago

Nice, I can look into this as well, and I'll add it as another item for the new workflow actions.

2bndy5 commented 2 years ago

FYI, the comment in the current cookiecutter workflow is outdated and can be entirely removed because actions/upload-release-asset is now archived (not supported anymore).

tekktrik commented 1 year ago

Fixed by https://github.com/adafruit/workflows-circuitpython-libs/pull/8