don't run tests twice

[jandelgado]

currently tests are run twice, both for the pull request and the push to the branch. The proposed change makes sure tests are only run once, speeding up CI run.

before:

after:

[tekktrik]

Hi! I'll take a look at this within the next 24 hours, but I believe these only run twice if the pull request branch and target branch are the same repository (with the same owner), correct? It seems that if a library gets a pull request from a contributor from a fork, as is now, it only runs once. The exception would be it someone with write access to the adafruit repository pull requested from a branch they created within the adafruit repository, or if a contributor pull requests to their own personal repository, then it runs twice. Please correct me if that's not correct.

If this is the cases, my inclination is to keep the CI as it is now for a few reasons:

• Contributors can set up GitHub Actions to run on their forks, and the CI as is now will run for all their pushes regardless of branch name. This makes it possible for contributors to test their submissions prior to the PR, while naming their branches freely.
• Typically maintainers only push to main the branch, but I can think of at least on library (the test repo library) that uses a branch called test to make sure riskier CI changes don't have an impact. This new change would break that.
• As mentioned before, this should only happens if the pull request branch and the target branch are within the same repository (including same owner). While this might benefit Community Bundle libraries, the two CI runs, at worst, typically run side by side (assuming runners are available) when an active PR branch receives a push, so it doesn't really save much time. Also the CI is currently ~3 minutes or so in length and fairly consistent, so not a huge loss there either.

Given the above, the benefit to Community Bundle libraries is minimal, and the potential impact to Adafruit Bundle libraries leans more negative, that's my thinking. Additionally, if this is an issue for a Community library, this change can always be made locally, but since the Adafruit and Community libraries share this bit, I'm inclined to weigh in favor of keeping things as is.