search

adafruit / cookiecutter-adafruit-circuitpython

Cookiecutter template for Adafruit's CircuitPython libraries.
MIT License
22 stars 37 forks source link

pylint fails CI on `monotonic_ns` due to old python version in Actions #85

Closed siddacious closed 3 years ago

siddacious commented 4 years ago

pylint_bug

The above pretty much explains it; monotonic_ns exists in both CircuitPython and C Python since 3.7; I'll suggest we start using at least 3.7 if not 3.8 for CI

@kattni @sommersoft @dherrada please take a look at the above and let me know if I'm missing something

siddacious commented 4 years ago

Here's the failure where I first noticed it: https://github.com/adafruit/Adafruit_CircuitPython_MCP2515/runs/1059350643?check_suite_focus=true

I can still work on the lib for now but this will block me from releasing

sommersoft commented 4 years ago

I don't have any objections to bumping the CPython version up. There may be some instances of keyword collisions (async, await as variable names, etc), but nothing that should be too heavy.

siddacious commented 4 years ago

@sommersoft is this (and the other workflow file) the only place that would need an update? https://github.com/adafruit/cookiecutter-adafruit-circuitpython/blob/master/%7B%7B%20cookiecutter.library_name%20%7D%7D/.github/workflows/release.yml#L27

lesamouraipourpre commented 3 years ago

@dherrada I've noticed you switching libraries to use CPython 3.7 in github actions. Is there a way to auto-close this when you've got through the list?

evaherrada commented 3 years ago

@lesamouraipourpre maybe... My personal plan is to just go through all the open issues and see which ones are related to pylint failing and close them. Oh, and I already got through the list. I ran it as an Adabot patch which saved me literal days and got them all done in like 15 mins

lesamouraipourpre commented 3 years ago

@dherrada I only found this because I has problems with a private repo which was still on CPython 3.6.

Thank you for all the excellent work you do tidying up with these, dare I sare monotonous, tasks.

evaherrada commented 3 years ago

@lesamouraipourpre Thanks. I'm glad to do it. Before adabot patches it was pretty bad, but now it only takes a few hours to write, test, and apply a patch to every library, compared to about a week before they were a thing.