multi .NET version targeting

adamfoneil / ModelSync

A C# model class and database schema comparison, SQL diff scripting library

MIT License

6 stars 2 forks source link

multi .NET version targeting #34

Open adamfoneil opened 1 year ago

adamfoneil commented 1 year ago

currently only NET Standard 2.0 is supported, but we need to target different .NET versions (Core 3.x+ and Framework 4.7+). The exact versions are negotiable. A few things we need here:

[x] support Core 3.1+ assemblies
[x] support .NET Framework assemblies
[ ] Integration test: Core test assembly (as embedded resource) demonstrating all attributes (Key, UniqueConstraint, Column, etc)
[ ] Integration test: Framework test assembly (as embedded resource), same as above

Please use branch feature/multi-targeting

adamfoneil commented 1 year ago

@usmanasfandiCheetah I believe you're already working on this. I just wanted to give a heads up I've moved this issue here.

usmanasfandiCheetah commented 1 year ago

System.Runtime 4.2.0 supports both types of assembly. Core and Standard Assembly that comes with Visual Studio version 17 and above. System.Runtime version 4.0 only supports Standard Framework Assembly that comes with Visual Studio version 16

usmanasfandiCheetah commented 1 year ago

Both Standard and Core Framework Assemblies are now readable and getting results as its supposed to be. All the attributes are also working except for the References attributes that need to be matched with the way entity framework is handling the foreign keys and dependency constraints.

adamfoneil commented 1 year ago

@usmanasfandiCheetah I don't think there should be any EF scope work under this issue -- that should be under #29. The main thing I'm looking for here are integration tests that show DataModel creation from Core and Framework assemblies. They can be very simple models.

adamfoneil commented 1 year ago

@usmanasfandiCheetah I don't see a test in here that would demonstrate multi-targeting. I was expecting to see an integration test using assemblies as embedded resources that would build simple models in Core and Framework.

adamfoneil commented 1 year ago

@usmanasfandiCheetah just some notes on our conversation earlier. You're going to add integration test, building on what I stubbed out in the Test project for EFAssemblySources. We're not going to implement the "AO" assemblies for now