search

adamthedeveloper / wepay-rails

Collect payments from wepay in your rails application.
MIT License
32 stars 24 forks source link

Also noticed a problem with precision and scale in the decimal columns #24

Open timothyjoh opened 11 years ago

timothyjoh commented 11 years ago

In the WePayCheckoutRecords migration, there is no definition to the precision and scale attributes on the :decimal columns, so Rails assumes a precision of 10 and a scale of 0, truncating any cents returned from Wepay.

I would suggest you put in a precision of 10, and scale of 2 in those columns.

SteveAquino commented 11 years ago

Thanks for pointing that out! I've only been using whole numbers up until now which is why I didn't see this sooner, will get this fixed in the next update.

timothyjoh commented 11 years ago

Yea I didn't feel it was worth a pull request.

Timothy Johnson www.wearefound.com 540 908-4445

http://youtube.com/foundvideostudio

http://youtube.com/jhnsntmthy

On Sep 17, 2012, at 3:27 PM, Steve Aquino notifications@github.com wrote:

Thanks for pointing that out! I've only been using whole numbers up until now which is why I didn't see this sooner, will get this fixed in the next update.

— Reply to this email directly or view it on GitHub.