search

adamwynne / twitter-api

Async io interface to all the twitter APIs
372 stars 64 forks source link

Some warnings from kibit #20

Closed seymores closed 11 years ago

seymores commented 11 years ago

Hi, Just thought this might be helpful to you -- I ran kibit through the latest code and got 2 warnings:

At /Users/seymores/work/github/twitter-api/src/twitter/callbacks/handlers.clj:60: Consider using: (str baos) instead of: (.toString baos)

At /Users/seymores/work/github/twitter-api/src/twitter/utils.clj:43: Consider using: (pos? (count result)) instead of: (> (count result) 0)

kibit https://github.com/jonase/kibit/

adamwynne commented 11 years ago

thanks for these - have used the pos?, but left the .toString, as the baos is a java object and I think its more consistent to use raw java calls on these objects