search

adamwynne / twitter-api

Async io interface to all the twitter APIs
372 stars 64 forks source link

Switching to ':require' instead of ':use' #68

Closed dotemacs closed 7 years ago

dotemacs commented 8 years ago

Switched to using :require instead of :use in the namespaces.

This change mostly owes it to this commit: https://github.com/arrdem/twitter-api/commit/8005a0ec24f1b2338ff9af646a9e5851a69279c7 by @arrdem.

There were a few other things in there that @arrdem changed, like docstrings and comments. By I intentionally left them as is, not to shift too much stuff around.

Maybe in the next PR I'll add in the changes as dictated by cljfmt: https://github.com/arrdem/twitter-api/commit/bec2edcd2e960440ee82ed15a06c8a14d647ca06.

dotemacs commented 8 years ago

Hey @adamwynne

what are your thoughts on this PR?

Thanks

arrdem commented 8 years ago

@dotemacs this repository hasn't seen activity in several years. I think it's fair to say that this project is abandoned. Also, following up after just 24hrs is pretty rude. Adam and I are hobbyists with other things to be doing than checking our email obsessively or reviewing pull requests. These things take time. Time for which we are not compensated, except by whatever pleasure we derive from working in our respective projects.

Why do you need these changes "upstreamed" to an inactive repo? Clearly you have your fork with some amount of my work in it, just use that and move on. I had no plans to try and push my code style work back here.

dotemacs commented 8 years ago

Hello @arrdem

thank you for taking the time out from your busy schedule to write a condescending, yet utterly irrelevant comment.

@dotemacs this repository hasn't seen activity in several years.

The last change that was merged was a PR that I made two days ago.

I think it's fair to say that this project is abandoned.

Is it comments like these that give you that picture:

https://github.com/adamwynne/twitter-api/issues/63#issuecomment-76685940

Also, following up after just 24hrs is pretty rude.

Not sure what @adamwynne age is but I'm sure that he can speak for himself and decide what's what.

I was just keen to see this change merged in. Especially since the last PR I made, the change was merged a few hours later.

While talking of rude, I'd say that comments like: "Good lord style" https://github.com/arrdem/twitter-api/commit/8005a0ec24f1b2338ff9af646a9e5851a69279c7 to me read more like a put down. But despite that, I thought some of those changes made sense. So instead of trying to pull in your changes with that comment, I thought it would be more constructive to add some of them, but to avoid your commit, precisely due to the comment.

Adam and I are hobbyists with other things to be doing than checking our email obsessively or reviewing pull requests. These things take time. Time for which we are not compensated, except by whatever pleasure we derive from working in our respective projects.

I'm sorry, but at what point was I asking you to do anything?

The PR was against @adamwynne's repo.

The changes are mostly inspired by your work and I mention you in the PR's write-up in order to honour your work. But the reason I wanted this work to be added back to this repo is because I thought that your style changes were idiomatic.

Why do you need these changes "upstreamed" to an inactive repo?

Not an inactive repo.

Because the previous PR was merged in. With these changes the next PR could be the version bump up and a new release.

But again, that is up to @adamwynne to decide.

Clearly you have your fork with some amount of my work in it, just use that and move on. I had no plans to try and push my code style work back here.

Good. Because nobody is asking you for anything. Feel free to ignore this PR.

adamwynne commented 8 years ago

guys - this is not the forum for this - the repo is not abandoned (but I agree I've been neglectful). I am the owner of repo and am its sole spokesperson. Lets keep the petty squabbles out of this. All PRs are gratefully appreciated.

chbrown commented 7 years ago

Hi @dotemacs, thanks for this PR, and apologies for the brusque initial response you got.

I've merged most of this PR as of 4220f85. A few remarks on the things I changed:

I'm going to be cutting a new release of this library soon and intend to continue to pitch in on its upkeep, so please keep the PRs coming!

dotemacs commented 7 years ago

@chbrown thank you