adamziel / Redmine-Todo-lists

Basecamp-like todo lists for redmine
MIT License
44 stars 22 forks source link

before_filter is undefined for TodoItemController:Class #71

Open shaoran opened 4 years ago

shaoran commented 4 years ago

I've installed the latest commit e93f409e82e8c5d28b6812c57d40f97a555ae295 on a redmine 4.0.5 installation (running on ruby-2.6.5).

I executed

$ bundle install --without development test
$ $ bundle exec rake redmine:plugins:migrate RAILS_ENV=production
/home/redmine/src/redmine-4.0.5/plugins/redmine_todos/init.rb:31: warning: key :todo_list is duplicated and overwritten on line 32
/home/redmine/src/redmine-4.0.5/plugins/redmine_todos/init.rb:42: warning: key :todo_item is duplicated and overwritten on line 43

and when I restart my app, I get this error:

$ thin start -e production
Using rack adapter
/home/redmine/src/redmine-4.0.5/plugins/redmine_todos/init.rb:31: warning: key :todo_list is duplicated and overwritten on line 32
/home/redmine/src/redmine-4.0.5/plugins/redmine_todos/init.rb:42: warning: key :todo_item is duplicated and overwritten on line 43
Traceback (most recent call last):
    56: from /home/redmine/.rvm/gems/ruby-2.6.5@redmine-next/bin/ruby_executable_hooks:24:in `<main>'
    55: from /home/redmine/.rvm/gems/ruby-2.6.5@redmine-next/bin/ruby_executable_hooks:24:in `eval'
    54: from /home/redmine/.rvm/gems/ruby-2.6.5@redmine-next/bin/thin:23:in `<main>'
    53: from /home/redmine/.rvm/gems/ruby-2.6.5@redmine-next/bin/thin:23:in `load'
    52: from /home/redmine/.rvm/gems/ruby-2.6.5@redmine-next/gems/thin-1.7.2/bin/thin:6:in `<top (required)>'
    51: from /home/redmine/.rvm/gems/ruby-2.6.5@redmine-next/gems/thin-1.7.2/lib/thin/runner.rb:159:in `run!'
    50: from /home/redmine/.rvm/gems/ruby-2.6.5@redmine-next/gems/thin-1.7.2/lib/thin/runner.rb:203:in `run_command'
    49: from /home/redmine/.rvm/gems/ruby-2.6.5@redmine-next/gems/thin-1.7.2/lib/thin/controllers/controller.rb:74:in `start'
    48: from /home/redmine/.rvm/gems/ruby-2.6.5@redmine-next/gems/thin-1.7.2/lib/thin/controllers/controller.rb:170:in `load_adapter'
    47: from /home/redmine/.rvm/gems/ruby-2.6.5@redmine-next/gems/thin-1.7.2/lib/rack/adapter/loader.rb:42:in `for'
    46: from /home/redmine/.rvm/gems/ruby-2.6.5@redmine-next/gems/thin-1.7.2/lib/rack/adapter/loader.rb:33:in `load'
    45: from /home/redmine/.rvm/gems/ruby-2.6.5@redmine-next/gems/thin-1.7.2/lib/rack/adapter/loader.rb:33:in `eval'
    44: from /home/redmine/src/redmine-4.0.5/config.ru:1:in `<main>'
    43: from /home/redmine/src/redmine-4.0.5/config.ru:1:in `new'
    42: from /home/redmine/.rvm/gems/ruby-2.6.5@redmine-next/gems/rack-2.0.7/lib/rack/builder.rb:55:in `initialize'
    41: from /home/redmine/.rvm/gems/ruby-2.6.5@redmine-next/gems/rack-2.0.7/lib/rack/builder.rb:55:in `instance_eval'
    40: from /home/redmine/src/redmine-4.0.5/config.ru:3:in `block in <main>'
    39: from /home/redmine/src/redmine-4.0.5/config.ru:3:in `require'
    38: from /home/redmine/src/redmine-4.0.5/config/environment.rb:14:in `<top (required)>'
    37: from /home/redmine/.rvm/gems/ruby-2.6.5@redmine-next/gems/railties-5.2.3/lib/rails/application.rb:361:in `initialize!'
    36: from /home/redmine/.rvm/gems/ruby-2.6.5@redmine-next/gems/railties-5.2.3/lib/rails/initializable.rb:60:in `run_initializers'
    35: from /home/redmine/.rvm/rubies/ruby-2.6.5/lib/ruby/2.6.0/tsort.rb:205:in `tsort_each'
    34: from /home/redmine/.rvm/rubies/ruby-2.6.5/lib/ruby/2.6.0/tsort.rb:226:in `tsort_each'
    33: from /home/redmine/.rvm/rubies/ruby-2.6.5/lib/ruby/2.6.0/tsort.rb:347:in `each_strongly_connected_component'
    32: from /home/redmine/.rvm/rubies/ruby-2.6.5/lib/ruby/2.6.0/tsort.rb:347:in `call'
    31: from /home/redmine/.rvm/rubies/ruby-2.6.5/lib/ruby/2.6.0/tsort.rb:347:in `each'
    30: from /home/redmine/.rvm/rubies/ruby-2.6.5/lib/ruby/2.6.0/tsort.rb:349:in `block in each_strongly_connected_component'
    29: from /home/redmine/.rvm/rubies/ruby-2.6.5/lib/ruby/2.6.0/tsort.rb:431:in `each_strongly_connected_component_from'
    28: from /home/redmine/.rvm/rubies/ruby-2.6.5/lib/ruby/2.6.0/tsort.rb:350:in `block (2 levels) in each_strongly_connected_component'
    27: from /home/redmine/.rvm/rubies/ruby-2.6.5/lib/ruby/2.6.0/tsort.rb:228:in `block in tsort_each'
    26: from /home/redmine/.rvm/gems/ruby-2.6.5@redmine-next/gems/railties-5.2.3/lib/rails/initializable.rb:61:in `block in run_initializers'
    25: from /home/redmine/.rvm/gems/ruby-2.6.5@redmine-next/gems/railties-5.2.3/lib/rails/initializable.rb:32:in `run'
    24: from /home/redmine/.rvm/gems/ruby-2.6.5@redmine-next/gems/railties-5.2.3/lib/rails/initializable.rb:32:in `instance_exec'
    23: from /home/redmine/.rvm/gems/ruby-2.6.5@redmine-next/gems/railties-5.2.3/lib/rails/application/finisher.rb:69:in `block in <module:Finisher>'
    22: from /home/redmine/.rvm/gems/ruby-2.6.5@redmine-next/gems/railties-5.2.3/lib/rails/application/finisher.rb:69:in `each'
    21: from /home/redmine/.rvm/gems/ruby-2.6.5@redmine-next/gems/railties-5.2.3/lib/rails/engine.rb:356:in `eager_load!'
    20: from /home/redmine/.rvm/gems/ruby-2.6.5@redmine-next/gems/railties-5.2.3/lib/rails/engine.rb:475:in `eager_load!'
    19: from /home/redmine/.rvm/gems/ruby-2.6.5@redmine-next/gems/railties-5.2.3/lib/rails/engine.rb:475:in `each'
    18: from /home/redmine/.rvm/gems/ruby-2.6.5@redmine-next/gems/railties-5.2.3/lib/rails/engine.rb:477:in `block in eager_load!'
    17: from /home/redmine/.rvm/gems/ruby-2.6.5@redmine-next/gems/railties-5.2.3/lib/rails/engine.rb:477:in `each'
    16: from /home/redmine/.rvm/gems/ruby-2.6.5@redmine-next/gems/railties-5.2.3/lib/rails/engine.rb:478:in `block (2 levels) in eager_load!'
    15: from /home/redmine/.rvm/gems/ruby-2.6.5@redmine-next/gems/activesupport-5.2.3/lib/active_support/dependencies.rb:246:in `require_dependency'
    14: from /home/redmine/.rvm/gems/ruby-2.6.5@redmine-next/gems/activesupport-5.2.3/lib/active_support/dependencies.rb:334:in `depend_on'
    13: from /home/redmine/.rvm/gems/ruby-2.6.5@redmine-next/gems/activesupport-5.2.3/lib/active_support/dependencies.rb:356:in `require_or_load'
    12: from /home/redmine/.rvm/gems/ruby-2.6.5@redmine-next/gems/activesupport-5.2.3/lib/active_support/dependencies.rb:37:in `load_interlock'
    11: from /home/redmine/.rvm/gems/ruby-2.6.5@redmine-next/gems/activesupport-5.2.3/lib/active_support/dependencies/interlock.rb:13:in `loading'
    10: from /home/redmine/.rvm/gems/ruby-2.6.5@redmine-next/gems/activesupport-5.2.3/lib/active_support/concurrency/share_lock.rb:151:in `exclusive'
     9: from /home/redmine/.rvm/gems/ruby-2.6.5@redmine-next/gems/activesupport-5.2.3/lib/active_support/dependencies/interlock.rb:14:in `block in loading'
     8: from /home/redmine/.rvm/gems/ruby-2.6.5@redmine-next/gems/activesupport-5.2.3/lib/active_support/dependencies.rb:37:in `block in load_interlock'
     7: from /home/redmine/.rvm/gems/ruby-2.6.5@redmine-next/gems/activesupport-5.2.3/lib/active_support/dependencies.rb:378:in `block in require_or_load'
     6: from /home/redmine/.rvm/gems/ruby-2.6.5@redmine-next/gems/activesupport-5.2.3/lib/active_support/dependencies.rb:291:in `require'
     5: from /home/redmine/.rvm/gems/ruby-2.6.5@redmine-next/gems/activesupport-5.2.3/lib/active_support/dependencies.rb:257:in `load_dependency'
     4: from /home/redmine/.rvm/gems/ruby-2.6.5@redmine-next/gems/activesupport-5.2.3/lib/active_support/dependencies.rb:291:in `block in require'
     3: from /home/redmine/.rvm/gems/ruby-2.6.5@redmine-next/gems/polyglot-0.3.5/lib/polyglot.rb:65:in `require'
     2: from /home/redmine/.rvm/gems/ruby-2.6.5@redmine-next/gems/polyglot-0.3.5/lib/polyglot.rb:65:in `require'
     1: from /home/redmine/src/redmine-4.0.5/plugins/redmine_todos/app/controllers/todo_item_controller.rb:1:in `<top (required)>'
/home/redmine/src/redmine-4.0.5/plugins/redmine_todos/app/controllers/todo_item_controller.rb:4:in `<class:TodoItemController>': undefined method `before_filter' for TodoItemController:Class (NoMethodError)
Did you mean?  before_action

Am I missing something here?

adamziel commented 4 years ago

Unfortunately I am not actively maintaining this plugin - I'd love to accept a Pull Request if you happen to figure out this one!