adi1090x / plymouth-themes

A huge collection (80+) of plymouth themes ported from android bootanimations
GNU General Public License v3.0
1.82k stars 116 forks source link

[WIP] [Feature] Support multiple animation states #9

Closed Ckarles closed 4 years ago

Ckarles commented 4 years ago

This is a WIP,

I'm posting this PR so I can have your opinion about this feature and if so discuss about its implementation.

There are different kinds of animations in this (cool) repo, most of them are loops, but some have "different states", like a fade-in animation, then a progress one.

The current script is perfect for a "loop" animation, because it's what it does, it loops through all of the images and most of the animations are great for that.

I've modified the script of "cross_hud" animation to experiment on having different "states", the early implementation 3886c26 does the following:

At boot, starts the "fade-in" animation, then merge to the "progress-in" animation.

I think it would be a cool addition to let the choice to have either a looped animation or a "progress" one.

Can you please give it a try and tell me what you think ?

adi1090x commented 4 years ago

Well, the idea is good... but the current one, you modified isn't working as expected, also it slow down the loop animation, i guess it's still WIP. I would love to see it working well.

Ckarles commented 4 years ago

Hello, Have you tried to boot with the initrd or only simulated it with the plymouth executable ? Because apparently, in the simulated "loading process", the completion % slows infinitely as it progresses.

When I'm booting a kernel+initrd with qemu I have the expected result (as when my workstation boots up):

Is it possible that your distribution/configuration sends different time/progress to plymouth ? Is the debug progress% shows something different ?

Also I've slowed down the animation extensively (0.3x) for development reasons.

adi1090x commented 4 years ago

Any Progress?

adi1090x commented 4 years ago

Closing it now, reopen again if you're ready to work on it.