fix : issue 45 - name argument included in sendOtp

aditya-garg-09-01-2002 / commencer

Bringing in commonly used APIs for building your unique projects

3 stars 10 forks source link

fix : issue 45 - name argument included in sendOtp #48

Closed hasin-zaman closed 4 days ago

hasin-zaman commented 4 days ago

closes #45

hasin-zaman commented 4 days ago

But user.profile is nullable shouldn't user.profile.name instead of user.profile!.name give error?

aditya-garg-09-01-2002 commented 4 days ago

The setup of user registration is such that forgot password won't ever work without setting up the profile, thus name and profile won't be null.
Even if due to some bug, this situation arises, the thing is user.profile! name only asserts profile is not null, but if user.profile is still, the error would occur irrespective of user.profile.name or user.profile!.name ( this will only shift compile time error to a run time error instead.

hasin-zaman commented 4 days ago

I have made the required changes. Can you review if they're okay? I had to typecast req.user = user as UserProps because it was expecting user.profile to be null even though I have kept it non nullable