admin-shell-io / aas-specs

Repository of the Asset Administration Shell Specification IDTA-01001 - Metamodel
https://industrialdigitaltwin.org/en/content-hub/aasspecifications
Creative Commons Attribution 4.0 International
45 stars 26 forks source link

[BUG] Reference/type is underspecified #389

Open arnoweiss opened 3 months ago

arnoweiss commented 3 months ago

Describe the bug It's unclear when the Reference/type should be set to "ModelReference". Options:

Where AAS Pt. 1, sec 5.3.10.2

Additional context Ideally, this property would signify to a Client whether to resolve the first key of a Reference locally or look it up in a Registry (either a SubmodelRegistry or a semanic catalog).

BirgitBoss commented 2 months ago

For all attributes with type ModelReference<{element}> it is clearly defined that a ModelReference shall be used (see Annex D).

for semanticId there will be an even clearer recommendation to only use ExternalReference in V3.1 (see https://github.com/admin-shell-io/aas-specs/issues/376) Similar for ValueId: https://github.com/admin-shell-io/aas-specs/issues/396

So your question is only open for SubmodelElement types ReferenceElement and RelationshipElement. Since there is no restriction in the specification all your examples are valid (and more, see below).

See also matching algorithms for SemanticId and References in chapter 4.4. There will be an update of these chapters in V3.1. See https://github.com/admin-shell-io/aas-specs/issues/347 and https://github.com/admin-shell-io/aas-specs/issues/350

The main question for dataspaces will be which kind of discovery services are available to find the referenced entities, whether via ExternalReference or ModelReference.

P.S. your list of possibilities is incomplete, the following is missing:

P.P.S. There is exactly one „Environment“ class for all servers since it is not identifiable.

BirgitBoss commented 2 months ago

I do not consider this to be a bug, remove tag „bug“