[BUG] Do not use keywords in the meta-model

admin-shell-io / aas-specs

Repository of the Asset Administration Shell Specification IDTA-01001 - Metamodel

https://admin-shell-io.github.io/aas-specs-antora/index/home/index.html

Creative Commons Attribution 4.0 International

48 stars 26 forks source link

[BUG] Do not use keywords in the meta-model #468

Open mristin opened 3 weeks ago

mristin commented 3 weeks ago

The class Endpoint contains a property called interface. This makes it ugly for the SDKs to call the property interfacE whenever it is a keyword in the respective language.

Please find attached to this comment a Python snippet (from https://github.com/aas-core-works/aas-core-codegen) listing all the keywords in all the popular programming languages.

Another problematic properties are type, range and result.

keywords-snippet.txt

BirgitBoss commented 2 weeks ago

Thank you making us aware of these keywords! I made a copy: https://github.com/admin-shell-io/aas-specs-api/issues/320 because the Endpoint you mentioned is defined in Part 2 API domain models. Since changes w.r.t. to attribute names would be non-backward compatible assignment and consideration for V4.x is suitable.