CIF-1285 - Product search is slow in product console and product picker

[LSantha]

• adjusted pagination in product picker search
• reuse resource returned in search hits during HTML output generation in GraphqlProductViewHandler
• optimize GraphQL query for product search
• update unit tests

Description

Product search performance improvements in product console, product picker and page editor asset finder.

Related Issue

CIF-1285

How Has This Been Tested?

Manually, unit tests.

Types of changes

• [X] Bug fix (non-breaking change which fixes an issue)
• [ ] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• [ ] I have signed the Adobe Open Source CLA.
• [ ] My change requires a change to the documentation.
• [ ] I have updated the documentation accordingly.
• [X] I have read the CONTRIBUTING document.
• [X] I have added tests to cover my changes and the overall coverage did not decrease.
• [X] All unit tests pass on CircleCi.
• [X] I ran all tests locally and they pass.

[codecov[bot]]

Codecov Report

Merging #101 into master will decrease coverage by 0.32%. The diff coverage is 91.66%.

@@             Coverage Diff              @@
##             master     #101      +/-   ##
============================================
- Coverage     87.54%   87.22%   -0.33%     
- Complexity      394      397       +3     
============================================
  Files            29       29              
  Lines          1582     1597      +15     
  Branches        227      231       +4     
============================================
+ Hits           1385     1393       +8     
- Misses           93       98       +5     
- Partials        104      106       +2

Flag	Coverage Δ	Complexity Δ
#integration	54.84% <70.83%> (+0.05%)	241 <5> (ø)	:arrow_down:
#karma	92.71% <ø> (-3.32%)	0 <ø> (ø)
#unittests	82.71% <83.33%> (-0.03%)	380 <7> (+3)

Impacted Files	Coverage Δ	Complexity Δ
...mmerce/graphql/magento/GraphqlDataServiceImpl.java	95.48% <100%> (-0.14%)	54 <1> (-1)
...mmerce/graphql/core/GraphqlProductViewHandler.java	80.13% <100%> (+2.19%)	18 <4> (+4)	:arrow_up:
...adobe/cq/commerce/graphql/core/MagentoProduct.java	83.51% <66.66%> (-1.55%)	55 <2> (ø)
...omponents/common/cifpicker/clientlibs/cifpicker.js	80% <0%> (-11.12%)	0% <0%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9c72f17...dbf65f5. Read the comment docs.

[codecov[bot]]

Codecov Report

Merging #101 into master will decrease coverage by 0.32%. The diff coverage is 91.66%.

@@             Coverage Diff              @@
##             master     #101      +/-   ##
============================================
- Coverage     87.54%   87.22%   -0.33%     
- Complexity      394      397       +3     
============================================
  Files            29       29              
  Lines          1582     1597      +15     
  Branches        227      231       +4     
============================================
+ Hits           1385     1393       +8     
- Misses           93       98       +5     
- Partials        104      106       +2

Flag	Coverage Δ	Complexity Δ
#integration	54.84% <70.83%> (+0.05%)	241 <5> (ø)	:arrow_down:
#karma	92.71% <ø> (-3.32%)	0 <ø> (ø)
#unittests	82.71% <83.33%> (-0.03%)	380 <7> (+3)

Impacted Files	Coverage Δ	Complexity Δ
...mmerce/graphql/magento/GraphqlDataServiceImpl.java	95.48% <100%> (-0.14%)	54 <1> (-1)
...mmerce/graphql/core/GraphqlProductViewHandler.java	80.13% <100%> (+2.19%)	18 <4> (+4)	:arrow_up:
...adobe/cq/commerce/graphql/core/MagentoProduct.java	83.51% <66.66%> (-1.55%)	55 <2> (ø)
...omponents/common/cifpicker/clientlibs/cifpicker.js	80% <0%> (-11.12%)	0% <0%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9c72f17...dbf65f5. Read the comment docs.

[mhaack]

verified