adobe / commerce-cif-connector

AEM Commerce connector for Magento and GraphQL
Apache License 2.0
43 stars 27 forks source link

CIF-1286 - Search support in category picker #102

Closed LSantha closed 4 years ago

LSantha commented 4 years ago

Related Issue

CIF-1286

Motivation and Context

Productivity features for large catalogs with hundreds or thousands of categories.

How Has This Been Tested?

Maunally, unit tests.

Screenshots (if appropriate):

Types of changes

Checklist:

codecov[bot] commented 4 years ago

Codecov Report

Merging #102 into master will decrease coverage by 0.07%. The diff coverage is 84.72%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #102      +/-   ##
============================================
- Coverage     87.54%   87.46%   -0.08%     
- Complexity      394      405      +11     
============================================
  Files            29       29              
  Lines          1582     1628      +46     
  Branches        227      232       +5     
============================================
+ Hits           1385     1424      +39     
- Misses           93       99       +6     
- Partials        104      105       +1
Flag Coverage Δ Complexity Δ
#integration 53.21% <26.38%> (-1.58%) 240 <1> (-1)
#karma 96.02% <ø> (ø) 0 <ø> (ø) :arrow_down:
#unittests 82.93% <84.72%> (+0.19%) 389 <9> (+12) :arrow_up:
Impacted Files Coverage Δ Complexity Δ
...cq/commerce/graphql/resource/CategoryResource.java 91.66% <100%> (+8.33%) 10 <0> (+3) :arrow_up:
...be/cq/commerce/graphql/magento/GraphqlQueries.java 98% <100%> (+0.22%) 18 <1> (+1) :arrow_up:
.../cifproductfield/impl/SearchDataSourceServlet.java 100% <100%> (ø) 4 <1> (ø) :arrow_down:
...mmerce/graphql/magento/GraphqlDataServiceImpl.java 92.76% <66.66%> (-2.86%) 59 <4> (+4)
...graphql/resource/GraphqlQueryLanguageProvider.java 80% <85.36%> (ø) 27 <3> (+3) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9c72f17...96277b6. Read the comment docs.

codecov[bot] commented 4 years ago

Codecov Report

Merging #102 into master will increase coverage by 0.29%. The diff coverage is 91.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #102      +/-   ##
============================================
+ Coverage     87.33%   87.63%   +0.29%     
- Complexity      406      409       +3     
============================================
  Files            29       29              
  Lines          1627     1642      +15     
  Branches        232      236       +4     
============================================
+ Hits           1421     1439      +18     
+ Misses          101       96       -5     
- Partials        105      107       +2
Flag Coverage Δ Complexity Δ
#integration 53.38% <70.83%> (+0.06%) 243 <5> (+2) :arrow_up:
#karma 96.02% <ø> (+3.31%) 0 <ø> (ø) :arrow_down:
#unittests 83.09% <83.33%> (-0.04%) 393 <7> (+3)
Impacted Files Coverage Δ Complexity Δ
...mmerce/graphql/magento/GraphqlDataServiceImpl.java 94.48% <100%> (-0.15%) 58 <1> (-1)
...mmerce/graphql/core/GraphqlProductViewHandler.java 80.13% <100%> (+2.19%) 18 <4> (+4) :arrow_up:
...adobe/cq/commerce/graphql/core/MagentoProduct.java 83.51% <66.66%> (-1.55%) 55 <2> (ø)
...omponents/common/cifpicker/clientlibs/cifpicker.js 91.11% <0%> (+11.11%) 0% <0%> (ø) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2e720a9...216b8ce. Read the comment docs.