adobe / commerce-cif-connector

AEM Commerce connector for Magento and GraphQL
Apache License 2.0
43 stars 27 forks source link

CIF-1182 - Use the same property type in components with product DnD #105

Closed cjelger closed 4 years ago

cjelger commented 4 years ago

How Has This Been Tested?

Extended unit tests and manually tested.

Types of changes

Checklist:

codecov[bot] commented 4 years ago

Codecov Report

Merging #105 into master will increase coverage by 0.08%. The diff coverage is 90.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #105      +/-   ##
============================================
+ Coverage     87.37%   87.45%   +0.08%     
- Complexity      438      454      +16     
============================================
  Files            32       33       +1     
  Lines          1734     1794      +60     
  Branches        255      272      +17     
============================================
+ Hits           1515     1569      +54     
- Misses          101      102       +1     
- Partials        118      123       +5     
Flag Coverage Δ Complexity Δ
#integration 50.69% <8.33%> (-1.61%) 249.00 <3.00> (+2.00) :arrow_down:
#karma 92.71% <ø> (ø) 0.00 <ø> (ø)
#unittests 83.62% <90.00%> (+0.24%) 438.00 <16.00> (+16.00)
Impacted Files Coverage Δ Complexity Δ
...stprocessor/MultiFieldDropTargetPostProcessor.java 90.00% <90.00%> (ø) 16.00 <16.00> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 908e0e1...dba8a24. Read the comment docs.

mhaack commented 4 years ago

Verified