LSantha commented 4 years ago

This is a preparatory PR to clean up some code features before the actual solution. Verification is not needed.

Description

cleanup of generics

Related Issue

CIF-1287

Motivation and Context

Simplification of code.

How Has This Been Tested?

Unit tests.

Types of changes

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] I have signed the Adobe Open Source CLA.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ X] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes and the overall coverage did not decrease.
[X] All unit tests pass on CircleCi.
[X] I ran all tests locally and they pass.

codecov[bot] commented 4 years ago

Codecov Report

Merging #106 into master will increase coverage by 0.00%. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master     #106   +/-   ##
=========================================
  Coverage     87.65%   87.65%           
  Complexity      460      460           
=========================================
  Files            34       34           
  Lines          1822     1823    +1     
  Branches        277      277           
=========================================
+ Hits           1597     1598    +1     
  Misses           99       99           
  Partials        126      126

Flag	Coverage Δ	Complexity Δ
#integration	`49.88% <71.42%> (+0.02%)`	`249.00 <3.00> (-1.00)`	:arrow_up:
#karma	`92.71% <ø> (ø)`	`0.00 <ø> (ø)`
#unittests	`83.91% <100.00%> (+<0.01%)`	`444.00 <6.00> (ø)`

Impacted Files	Coverage Δ	Complexity Δ
...graphql/resource/GraphqlQueryLanguageProvider.java	`80.20% <100.00%> (+0.20%)`	`27.00 <5.00> (ø)`
...erce/graphql/resource/GraphqlResourceProvider.java	`88.23% <100.00%> (+0.73%)`	`12.00 <0.00> (ø)`
...aphql/resource/GraphqlResourceProviderFactory.java	`97.95% <100.00%> (ø)`	`12.00 <1.00> (ø)`
...e/cq/commerce/graphql/resource/ResourceMapper.java	`79.25% <100.00%> (-0.22%)`	`40.00 <0.00> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7f61238...2e3923a. Read the comment docs.