Closed dplaton closed 4 years ago
Merging #111 into master will decrease coverage by
0.27%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #111 +/- ##
============================================
- Coverage 87.92% 87.65% -0.28%
Complexity 460 460
============================================
Files 34 34
Lines 1822 1822
Branches 277 277
============================================
- Hits 1602 1597 -5
- Misses 94 99 +5
Partials 126 126
Flag | Coverage Δ | Complexity Δ | |
---|---|---|---|
#integration | 49.85% <ø> (ø) |
250 <ø> (+1) |
:arrow_up: |
#karma | 92.71% <ø> (-3.32%) |
0 <ø> (ø) |
|
#unittests | 83.9% <ø> (ø) |
444 <ø> (ø) |
:arrow_down: |
Impacted Files | Coverage Δ | Complexity Δ | |
---|---|---|---|
...omponents/common/cifpicker/clientlibs/cifpicker.js | 80% <0%> (-11.12%) |
0% <0%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 06e7b83...be38a72. Read the comment docs.
Merging #111 into master will increase coverage by
0.73%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #111 +/- ##
============================================
+ Coverage 87.19% 87.92% +0.73%
Complexity 460 460
============================================
Files 30 34 +4
Lines 1671 1822 +151
Branches 277 277
============================================
+ Hits 1457 1602 +145
- Misses 88 94 +6
Partials 126 126
Flag | Coverage Δ | Complexity Δ | |
---|---|---|---|
#integration | 49.85% <ø> (ø) |
250.00 <ø> (ø) |
|
#karma | 96.02% <ø> (?) |
0.00 <ø> (?) |
|
#unittests | 83.90% <ø> (ø) |
444.00 <ø> (ø) |
Impacted Files | Coverage Δ | Complexity Δ | |
---|---|---|---|
...n/cifcategoryfield/clientlibs/cifcategorypicker.js | 97.05% <0.00%> (ø) |
0.00% <0.00%> (?%) |
|
...mon/cifproductfield/clientlibs/cifproductpicker.js | 97.05% <0.00%> (ø) |
0.00% <0.00%> (?%) |
|
...omponents/common/cifpicker/clientlibs/cifpicker.js | 91.11% <0.00%> (ø) |
0.00% <0.00%> (?%) |
|
...oring/editor/pagepreview/clientlibs/pagepreview.js | 100.00% <0.00%> (ø) |
0.00% <0.00%> (?%) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 715bc47...5245e42. Read the comment docs.
Description
Update the
GraphqlProductViewHandlerTest
to useSystem.lineSeparator()
instead of hard-coding "\n" (fixes #107)Related Issue
CIF-1336
Motivation and Context
Fix the build process on Windows platforms
How Has This Been Tested?
Functional testing
Screenshots (if appropriate):
Types of changes
Checklist: