adobe / commerce-cif-connector

AEM Commerce connector for Magento and GraphQL
Apache License 2.0
43 stars 27 forks source link

Clean up cloud services config dialog #115

Closed mhaack closed 4 years ago

mhaack commented 4 years ago

Description

Clean up cloud services config dialog labels & description, set default values where possible and make store view optionally as it falls back to default if empty.

Related Issue

CIF-1341

Motivation and Context

Simplify configuration for authors.

Screenshots (if appropriate):

Screenshot 2020-04-03 at 11 11 34

Types of changes

Checklist:

codecov[bot] commented 4 years ago

Codecov Report

Merging #115 into master will increase coverage by 0.27%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #115      +/-   ##
============================================
+ Coverage     87.65%   87.93%   +0.27%     
  Complexity      460      460              
============================================
  Files            34       34              
  Lines          1823     1823              
  Branches        277      277              
============================================
+ Hits           1598     1603       +5     
+ Misses           99       94       -5     
  Partials        126      126
Flag Coverage Δ Complexity Δ
#integration 49.88% <ø> (ø) 250 <ø> (+1) :arrow_up:
#karma 96.02% <ø> (+3.31%) 0 <ø> (ø) :arrow_down:
#unittests 83.91% <ø> (ø) 444 <ø> (ø) :arrow_down:
Impacted Files Coverage Δ Complexity Δ
...omponents/common/cifpicker/clientlibs/cifpicker.js 91.11% <0%> (+11.11%) 0% <0%> (ø) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8f7871e...e5206c8. Read the comment docs.