Description

Products are not available in product console when using a Magento store view other than default.

Related Issue

CIF-1347

How Has This Been Tested?

Manually.

Types of changes

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] I have signed the Adobe Open Source CLA.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[X] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes and the overall coverage did not decrease.
[X] All unit tests pass on CircleCi.
[X] I ran all tests locally and they pass.

codecov[bot] commented 4 years ago

Codecov Report

Merging #118 into master will increase coverage by 2.58%. The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #118      +/-   ##
============================================
+ Coverage     85.46%   88.05%   +2.58%     
- Complexity      440      448       +8     
============================================
  Files            34       34              
  Lines          1782     1783       +1     
  Branches        274      274              
============================================
+ Hits           1523     1570      +47     
+ Misses          131       88      -43     
+ Partials        128      125       -3

Flag	Coverage Δ	Complexity Δ
#integration	`51.96% <100.00%> (+40.46%)`	`249.00 <0.00> (+204.00)`
#karma	`96.02% <ø> (+3.31%)`	`0.00 <ø> (ø)`
#unittests	`83.94% <100.00%> (+<0.01%)`	`432.00 <0.00> (ø)`

Impacted Files	Coverage Δ	Complexity Δ
.../adobe/cq/commerce/graphql/resource/Constants.java	`0.00% <ø> (ø)`	`0.00 <0.00> (ø)`
...aphql/resource/GraphqlResourceProviderFactory.java	`98.00% <100.00%> (+4.12%)`	`12.00 <0.00> (+1.00)`
...mmerce/graphql/magento/GraphqlDataServiceImpl.java	`92.73% <0.00%> (+1.11%)`	`64.00% <0.00%> (ø%)`
...mnisearch/ProductsSuggestionOmniSearchHandler.java	`89.88% <0.00%> (+4.49%)`	`14.00% <0.00%> (+2.00%)`
.../cq/commerce/graphql/resource/ProductResource.java	`90.00% <0.00%> (+5.00%)`	`16.00% <0.00%> (+1.00%)`
...erce/graphql/resource/GraphqlResourceProvider.java	`88.23% <0.00%> (+5.88%)`	`12.00% <0.00%> (+1.00%)`
...e/renderconditions/IsProductDetailPageServlet.java	`93.54% <0.00%> (+6.45%)`	`11.00% <0.00%> (+1.00%)`
...cq/commerce/graphql/resource/CategoryResource.java	`92.85% <0.00%> (+10.71%)`	`9.00% <0.00%> (+1.00%)`
...omponents/common/cifpicker/clientlibs/cifpicker.js	`91.11% <0.00%> (+11.11%)`	`0.00% <0.00%> (ø%)`
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7143e03...854a524. Read the comment docs.

LSantha commented 4 years ago

There are occurrences of cq:magentoStore only in tests besides that one which was added now to the code for backwards compatibility with the old configurations. The tests with occurrences are covering cases of backwards compatibility.

dkuntze commented 4 years ago

Wouldn't the better fix be to change the .content.xml that sets this property to the existing value vs this new value - thereby keeping any legacy code operating as is?