adobe / commerce-cif-connector

AEM Commerce connector for Magento and GraphQL
Apache License 2.0
43 stars 27 forks source link

CIF-1377 - NPE when connector configuration is installed via content … #123

Closed cjelger closed 4 years ago

cjelger commented 4 years ago

…package

How Has This Been Tested?

Added unit test.

Types of changes

Checklist:

codecov[bot] commented 4 years ago

Codecov Report

Merging #123 into master will increase coverage by 0.28%. The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #123      +/-   ##
============================================
+ Coverage     87.77%   88.05%   +0.28%     
- Complexity      448      450       +2     
============================================
  Files            34       34              
  Lines          1783     1783              
  Branches        274      274              
============================================
+ Hits           1565     1570       +5     
+ Misses           93       88       -5     
  Partials        125      125              
Flag Coverage Δ Complexity Δ
#integration 51.96% <33.33%> (ø) 249.00 <1.00> (ø)
#karma 96.02% <ø> (+3.31%) 0.00 <ø> (ø)
#unittests 83.94% <100.00%> (ø) 434.00 <4.00> (+2.00)
Impacted Files Coverage Δ Complexity Δ
...mmerce/graphql/magento/GraphqlDataServiceImpl.java 92.73% <100.00%> (ø) 66.00 <4.00> (+2.00)
...omponents/common/cifpicker/clientlibs/cifpicker.js 91.11% <0.00%> (+11.11%) 0.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 304694c...9dedcad. Read the comment docs.