CIF-1393 - Automatic product binding creation fails

[dplaton]

Description

The cif-virtual-catalog bundle was failing during activation because the service user mapping wasn't installed yet. To avoid this problem, we moved the service user mapping in the bundle and use the Sling-Initial-Content configuration to instruct the Maven Bundle Plugin to install them.

Related Issue

CIF-1393

Motivation and Context

Fix the bug which was causing the product binding not to be created automatically

How Has This Been Tested?

Functional testing

Screenshots (if appropriate):

Types of changes

• [X] Bug fix (non-breaking change which fixes an issue)
• [ ] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• [x] I have signed the Adobe Open Source CLA.
• [x] My change requires a change to the documentation.
• [ ] I have updated the documentation accordingly.
• [x] I have read the CONTRIBUTING document.
• [ ] I have added tests to cover my changes and the overall coverage did not decrease.
• [] All unit tests pass on CircleCi.
• [x] I ran all tests locally and they pass.

[codecov[bot]]

Codecov Report

Merging #125 into master will decrease coverage by 0.45%. The diff coverage is 25.00%.

@@             Coverage Diff              @@
##             master     #125      +/-   ##
============================================
- Coverage     87.91%   87.46%   -0.46%     
+ Complexity      492      491       -1     
============================================
  Files            35       35              
  Lines          1886     1890       +4     
  Branches        289      290       +1     
============================================
- Hits           1658     1653       -5     
- Misses           97      105       +8     
- Partials        131      132       +1     

Flag	Coverage Δ	Complexity Δ
#integration	47.03% <0.00%> (-2.42%)	248.00 <0.00> (-5.00)
#karma	92.71% <ø> (-3.32%)	0.00 <ø> (ø)
#unittests	83.89% <25.00%> (-0.14%)	476.00 <1.00> (ø)

Impacted Files	Coverage Δ	Complexity Δ
...rtual/catalog/data/impl/ProductBindingCreator.java	76.82% <25.00%> (-2.66%)	14.00 <1.00> (ø)
...omponents/common/cifpicker/clientlibs/cifpicker.js	80.00% <0.00%> (-11.12%)	0.00% <0.00%> (ø%)
...mnisearch/ProductsSuggestionOmniSearchHandler.java	88.76% <0.00%> (-1.13%)	13.00% <0.00%> (-1.00%)

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7368826...b44c76f. Read the comment docs.