adobe / commerce-cif-connector

AEM Commerce connector for Magento and GraphQL
Apache License 2.0
43 stars 27 forks source link

CIF-1393 - Automatic product binding creation fails #126

Closed dplaton closed 4 years ago

dplaton commented 4 years ago

Description

Several changes in this PR:

Related Issue

CIF-1393

Motivation and Context

Some components fail to activate because the service user mapping is not available at that time.

How Has This Been Tested?

Functional testing

Screenshots (if appropriate):

Types of changes

Checklist:

codecov[bot] commented 4 years ago

Codecov Report

Merging #126 into master will decrease coverage by 0.53%. The diff coverage is 14.28%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #126      +/-   ##
============================================
- Coverage     87.91%   87.37%   -0.54%     
  Complexity      492      492              
============================================
  Files            35       35              
  Lines          1886     1893       +7     
  Branches        289      291       +2     
============================================
- Hits           1658     1654       -4     
- Misses           97      106       +9     
- Partials        131      133       +2     
Flag Coverage Δ Complexity Δ
#integration 49.25% <0.00%> (-0.20%) 253.00 <0.00> (ø)
#karma 92.71% <ø> (-3.32%) 0.00 <ø> (ø)
#unittests 83.75% <14.28%> (-0.29%) 476.00 <1.00> (ø)
Impacted Files Coverage Δ Complexity Δ
...mnisearch/ProductsSuggestionOmniSearchHandler.java 89.88% <ø> (ø) 14.00 <0.00> (ø)
...a/impl/CatalogDataResourceProviderManagerImpl.java 80.93% <0.00%> (-1.15%) 44.00 <0.00> (ø)
...rtual/catalog/data/impl/ProductBindingCreator.java 76.82% <25.00%> (-2.66%) 14.00 <1.00> (ø)
...omponents/common/cifpicker/clientlibs/cifpicker.js 80.00% <0.00%> (-11.12%) 0.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7368826...7cc19f3. Read the comment docs.