adobe / commerce-cif-connector

AEM Commerce connector for Magento and GraphQL
Apache License 2.0
43 stars 27 forks source link

CIF-1394 - Product asset drag'n'drop on a page should configure produ… #130

Closed cjelger closed 4 years ago

cjelger commented 4 years ago

…ct teaser

Motivation and Context

The AEM drag and drop is handled by the Sling @CopyFrom request parameter which is basically a POST that copies data from one location to another, but does not store data at the request URL. This PR takes care of that.

How Has This Been Tested?

Extended unit tests and manually tested.

Types of changes

Checklist:

codecov[bot] commented 4 years ago

Codecov Report

Merging #130 into master will increase coverage by 0.07%. The diff coverage is 91.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #130      +/-   ##
============================================
+ Coverage     87.37%   87.45%   +0.07%     
- Complexity      492      495       +3     
============================================
  Files            35       35              
  Lines          1893     1905      +12     
  Branches        291      293       +2     
============================================
+ Hits           1654     1666      +12     
  Misses          106      106              
  Partials        133      133              
Flag Coverage Δ Complexity Δ
#integration 48.91% <0.00%> (-0.34%) 253.00 <0.00> (ø)
#karma 92.71% <ø> (ø) 0.00 <ø> (ø)
#unittests 83.86% <91.66%> (+0.11%) 479.00 <1.00> (+3.00)
Impacted Files Coverage Δ Complexity Δ
...stprocessor/MultiFieldDropTargetPostProcessor.java 91.66% <91.66%> (+1.66%) 19.00 <1.00> (+3.00)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c482829...2413b68. Read the comment docs.